Add UIBinding deprecation warnings to avoid misuse #284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `@UIBinding` property wrapper is meant as a substitute for `@State`, where you can introduce local, owned state to a view controller that can be strongly held in another child, but because it is completely unconstrained it was easy to reach for instead of `@UIBindable` when it came to view models, and those view models could be retained too strongly. This PR introduces a couple deprecated overloads to catch this misuse and guide folks towards `@UIBindable`, instead. We might want to consider this subtlety a bit more and rethink or better document the differences.
3 tasks
|
Had to comment out another Windows CI. We can revisit if we ever get a fix here: pointfreeco/swift-issue-reporting#156 |
mbrandonw
approved these changes
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
@UIBindingproperty wrapper is meant as a substitute for@State, where you can introduce local, owned state to a view controller that can be strongly held in another child, but because it is completely unconstrained it was easy to reach for instead of@UIBindablewhen it came to view models, and those view models could be retained too strongly.This PR introduces a couple deprecated overloads to catch this misuse and guide folks towards
@UIBindable, instead.We might want to consider this subtlety a bit more and rethink or better document the differences.
Addresses #283.